whir-svo#204
Open
TomWambsgans wants to merge 39 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
4cc57d4 to
9b44b59
Compare
…_batched` Co-authored-by: Copilot <copilot@github.com>
# Conflicts: # crates/whir/src/open.rs
c6f9fd4 to
c09c85a
Compare
Co-Authored-By: carlo <carlo.modica@protonmail.com>
Open
# Conflicts: # crates/whir/src/open.rs
Adopt main's always-IV slice hashing (length absorbed into the IV for domain separation) while keeping whir-split-eq's existing zero-skip optimization at the DFT layer (commit_with_prefix_len / reorder_and_dft_with_prefix_len). The Merkle layer keeps the simpler merkle_commit(matrix, n_cols) API and hashes the full DFT matrix, since the DFT already cut trailing zeros. Concretely: - precompute_zero_suffix_state + hash_rtl_iter_with_initial_state added to the sponge module (alongside the existing hash_iter). - whir/src/merkle.rs first_digest_layer switched to RTL absorption seeded with [base_width, 0, ..., 0], via the new vertically_packed_row_rtl matrix helper (n_zero_chunks = 0). - backend merkle_verify and fiat-shamir verifier swap hash_iter for hash_slice so the verifier reproduces the prover's IV-based digest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
c5a3050 to
9dc5d68
Compare
Adapts main's 'Custom thread pool (#239)' (rayon -> parallel crate) to the whir-split-eq refactor. This branch's SVO / LSB-first-fold WHIR prover supersedes main's WHIR statement-combining: kept whir-split-eq's unpacked Vec<EF> weights, compute_eval_eq_base_batched, LSB-cols FFT-prep layout, and svo.rs, dropping main's superseded combine_statement / compute_eval_eq_base_packed_batched. Converted all of whir-split-eq's rayon (svo.rs, open.rs) to the pool, and made build_accumulators sequential across groups since the pool forbids the nested dispatch rayon allowed (each group still parallelizes internally). Adapted lsb_fold to main's reworked fold_multilinear_at_bit API. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reconcile main's arena-allocator migration (#247, "remove global_allocator in zk-alloc") with the WHIR split-eq refactor on this branch. Conflicts resolved: - quotient_gkr/layers.rs: materialise_in_full keeps the branch's pub(super) visibility and adopts main's ArenaVec return type. - whir/utils.rs: keep the split-eq LSB-cols FFT-prep layout but write into an ArenaVec via par_fill (main's allocator) instead of par_map_collect's Vec; drop the now-unused log2_strict_usize import. - whir/open.rs: keep the branch's final_round / open_merkle_tree_at_challenges refactor and SVO sumcheck; drop main's combine_statement (deleted on this branch). Propagate main's ArenaVec migration through the new SVO helpers (SumcheckSingle.weights, lsb_fold, fold_by_tensor, build_post_svo_weights) to avoid Vec<->ArenaVec copies in the prover hot path. Auto-merges verified coherent: eq_mle.rs composes the branch's compute_eval_eq_base_batched rename/unpacked-output with main's ArenaVec buffers; commit.rs changes are in disjoint methods. cargo fmt / clippy clean; cargo testall (release) green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.